Fix open-as-root crash#3801
Open
Cognomines wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a crash when invoking Open as Root from the desktop on Wayland by avoiding the desktop view’s NULL window/slot path and by hardening URI/path handling against NULL returns.
Changes:
- Reworks the Wayland open-as-admin path to spawn a new
nemoprocess with anadmin://URI instead of opening via the current view’s slot/window. - Adds
NULLchecks around selection/view URI → path conversion to prevent crashes on non-native/invalid locations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+7203
to
+7210
| gchar *argv[3]; | ||
| argv[0] = "nemo"; | ||
| argv[1] = uri; | ||
| argv[2] = NULL; | ||
| GPid pid; | ||
| g_spawn_async (NULL, argv, NULL, G_SPAWN_SEARCH_PATH | G_SPAWN_DO_NOT_REAP_CHILD, | ||
| NULL, NULL, &pid, NULL); | ||
| g_child_watch_add (pid, (GChildWatchFunc) cb_open_as_root_watch, NULL); |
Member
|
I get using spawn for nemo-desktop, but there's no need for it from the windowed nemo process - the original I think we should maybe also gate this on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix crash when using Open as Root
Cause
On Wayland,
nemo-desktopuses theopen_as_admin()code path. This function callednemo_window_slot_open_location()usingview->details->slot, which ultimately resolves toslot->pane->window. In the desktop view context this window pointer isNULL, causing an assertion failure innemo-window-manage-views.c.Additionally,
open_as_admin()constructed an invalid admin URI usingg_uri_build(), producingadmin:/pathinstead of the expectedadmin:///path. Several code paths also assumed thatnemo_view_get_uri(),nemo_file_get_path(), andg_file_get_path()could never returnNULL.Solution
This patch changes
open_as_admin()to launch a newnemoprocess with a correctly constructedadmin://URI, matching the behavior of the non-Waylandopen_as_root()implementation. This avoids dereferencing the desktop view's window entirely.It also adds
NULLchecks for URI and path retrieval functions so invalid or non-native paths are handled gracefully instead of crashing.Testing
Tested on Hyprland using
nemo-gitbuilt withmeson -Dgtk_layer_shell=true. After applying this patch, selecting Open as Root from both the desktop icon context menu and the desktop background context menu no longer causesnemo-desktopto crash.