Conversation
Collaborator
Collaborator
thespad
approved these changes
Apr 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I tested this by using it for a new repo and ensuring the whole workflow is there.
The only thing I would say is missing from this is hyper optimization for vscodium, there is likely a bunch of stuff needed to support plugins there. But considering vscodium is provided as a helper in this container and not the main event I think a stock install is sufficient as all of your git interactions should be going through github-desktop.
In the future I would like to get this on aarch64 as well, but it will require building from source and making a series of modifications to the yarn build process to not pull in pre-built bins for things. In general it is a safer bet to start with x86_64 initially using a known distributed package that works on debian installs.
All apps are wrapped to run without seccomp unconfined and all user data will be in the /config folder as far as I can tell with my testing.