fix: remove Firefox VP9 SVC workaround#2002
Open
jibon57 wants to merge 2 commits into
Open
Conversation
jibon57
requested review from
1egoman,
lukasIO and
xianshijing-lk
as code owners
🦋 Changeset detectedLatest commit: 5694443 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
1egoman
requested review from
cnderrauber
and removed request for
1egoman and
xianshijing-lk
Contributor
|
Thanks for the contribution! I think @lukasIO / @cnderrauber are probably best to review this. |
Contributor
|
thanks for the PR. Just as a heads up, we’ll need to verify that this is actually fixed and addresses the specific SVC case and not “just” simulcast. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the workaround that disabled VP9 publishing for Firefox clients. According to the linked Bugzilla thread, this issue has been resolved in modern Firefox versions.
Fixes: https://bugzilla.mozilla.org/show_bug.cgi?id=1633876
Discussion: https://livekit-users.slack.com/archives/C025KM0S1CK/p1783681641812789