Add directional/charging skip toggles to Low, High and Battery alarms#692
Open
bjorkert wants to merge 2 commits into
Open
Add directional/charging skip toggles to Low, High and Battery alarms#692bjorkert wants to merge 2 commits into
bjorkert wants to merge 2 commits into
Conversation
The low alarm can now stay silent while BG is climbing, firing only when the latest reading is flat or still falling. Off by default, so existing alarms are unaffected.
The high alarm can now stay silent while BG is falling (mirror of the low alarm's skip-if-rising). The phone-battery alarm can stay silent while the phone is charging, using the uploader's charging status from Nightscout. Both are off by default.
bjorkert
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three opt-in toggles that keep alarms quiet when the situation is already correcting itself. All are off by default, so existing alarms behave exactly as before.
For the BG alarms, direction is judged by the last two readings; the delta isn't configurable. The battery toggle relies on the
isChargingflag already present in the Nightscout devicestatus payload rather than guessing from battery-level history.