Remove migration step 1 and the legacy UserDefaults framework#698
Open
bjorkert wants to merge 1 commit into
Open
Remove migration step 1 and the legacy UserDefaults framework#698bjorkert wants to merge 1 commit into
bjorkert wants to merge 1 commit into
Conversation
… alive Step 1 shipped in v3.0.0 (2025-07-07) and its one-year window has passed. It was already unreachable: migrationStep defaults to 9, so any user without a stored migrationStep skips every step, and users who have one are at >= 1. Removing migrateStep1() also retires its exclusive dependencies: the UserDefaultsValue / ObservableUserDefaultsValue stack, UserDefaultsValueGroups, ObservableUserDefaults, ObservationToken, AnyConvertible, and the orphaned HKQuantity+AnyConvertible. Nothing in Swift reads the app-group UserDefaults suite anymore, so AppConstants.APP_GROUP_ID goes too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 1 shipped in v3.0.0 (2025-07-07), so its one-year removal window has passed.
Deleting
migrateStep1()(and its 21 private alarm migrations) retires the whole legacy storage stack it was the last consumer of:UserDefaultsValue/ObservableUserDefaultsValueUserDefaultsValueGroupsObservableUserDefaults(only held theold_*keys)ObservationToken,AnyConvertibleHKQuantity+AnyConvertible— already an orphan, not in the pbxproj, referencing aUserDefaultsRepositorytype that no longer existsAlso drops an unused
ObservableUserDefaults.sharedproperty inContactSettingsViewModelandAppConstants.APP_GROUP_ID, whose only readers were the deleted value classes. Nothing in Swift reads the app-group UserDefaults suite now; the entitlements are left untouched.Reminder: step 2 expires 2026-07-21 and can be removed then.