DM-54548 : Add Conditional Nodeset to Check Jobs#92
Open
tcjennings wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
==========================================
- Coverage 84.80% 84.78% -0.02%
==========================================
Files 19 19
Lines 4245 4260 +15
Branches 456 458 +2
==========================================
+ Hits 3600 3612 +12
- Misses 567 570 +3
Partials 78 78 ☔ View full report in Codecov by Harness. |
8815d7e to
bc85a78
Compare
mxk62
approved these changes
Jul 9, 2026
| if defined JOB_NODESET | ||
| requirements=( Target.Nodeset == "$(JOB_NODESET)" ) | ||
| +JobNodeset = "$(JOB_NODESET)" | ||
| endif |
Collaborator
There was a problem hiding this comment.
A minor nitpick, but can we keep the capitalization of our custom macros consistent and use job_nodeset instead of JOB_NODESET?
- conditionally add a JobNodeset attribute to check job sub file. - add change fragment to docs/changes
659eb34 to
f5ca219
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resulting DAG file has VARS available for the check jobs, which is conditionally used in the static sub file these jobs use, e.g.:
The job ClassAd then has the appropriate JobNodeset values as set in the sub file, similar to other dag jobs, e.g.:
Checklist
doc/changes