fix(lib): remove callable signature without new from Intl.PluralRules…#63608
Open
SiddGud wants to merge 1 commit into
Open
fix(lib): remove callable signature without new from Intl.PluralRules…#63608SiddGud wants to merge 1 commit into
SiddGud wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #63606
Backlogmilestone (required)mainbranchhereby runtestslocallyPer ECMA-402 section 18.1.1 (
Intl.PluralRules(...)), ifNewTargetisundefined, aTypeErrorexception is thrown. Unlike legacy constructors (DateTimeFormat,NumberFormat,Collator) which have legacy fallback call behavior, modern Intl constructors requirenew.This PR removes the callable signature from
PluralRulesConstructorin bothes2018.intl.d.tsandes2020.intl.d.ts. Other ES2020+ constructors (such asRelativeTimeFormatandLocale) were audited and correctly only requirenew.