You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On Windows, the current code silently drops or misroutes Ctrl+Space. This PR extracts the per-event decision into a unit-testable
function translate_key_event and normalizes all three forms to NUL (vk::NULL).
This fix was discovered and remediated using Copilot. Human review and feedback requested.
For Ctrl+Space on Windows, it would be worth testing the interaction with IME/input-language switching as well as the editor command binding. Some Windows setups reserve that chord for toggling input methods, so the implementation should probably document whether Edit receives the key event only when the terminal passes it through. A small integration note for Windows Terminal vs classic console would make support issues easier to triage.
Added a focused Windows input translation test for the IME/input-language case: if Ctrl+Space/Space arrives with a real produced character, including a non-ASCII IME-style character, Edit preserves it as text input instead of normalizing it to the editor command binding.
Also added a README note documenting the behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, the current code silently drops or misroutes
Ctrl+Space. This PR extracts the per-event decision into a unit-testablefunction
translate_key_eventand normalizes all three forms toNUL(vk::NULL).This fix was discovered and remediated using Copilot. Human review and feedback requested.