ENH: add overlay Brain GUI#14031
Open
payamsash wants to merge 1 commit into
Open
Conversation
Member
|
Feel free to ping me when to look or try! Bonus points if you update an example to show this... maybe use multiple (dSPM, sLORETA, eLORETA?) solvers in https://mne.tools/stable/auto_tutorials/inverse/30_mne_dspm_loreta.html and overlay them with some suitable alpha and different colormaps (red/green/blue?). It could make for a cool visualization at the end of the example, and then easy to test interactively. But not obligatory if you have other ideas! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
following #13995 and "We also have an issue with interactivity, in that the Brain interface can have widgets that control colorbar limits for example. So we'll want to add a "data key" (maybe there is some better name?) drop-down there that allows controlling the limits for the given key / set of data, and we'll need some private var to track the currently "active" (meaning: colorbar is the one shown, and the limits / smoothing etc. changed by GUI interaction) data key."
What does this implement/fix?
Add a box next to the "Color Limits", (it should be hidden when there's only one overlay), switching it should update
_active_data_keyand refresh thefmin/fmid/fmax/smoothingsliders. so whenadd_data(remove_existing=False)is called after the viewer is already open, the box should update its items. but we'd need to add a smallset_items(items)method to_AbstractWdgtand put it in both_qt.pyand_notebook.py, because now theset_rangecallssetRange(min, max)which is numeric-only and not compatible withQComboBox.not sure if there's a simpler way? @larsoner
Additional information
I'll probably use Claude AI for code review.