fix(files_sharing): limit the share token input to the maximum token length#61826
Open
MiMoHo wants to merge 2 commits into
Open
fix(files_sharing): limit the share token input to the maximum token length#61826MiMoHo wants to merge 2 commits into
MiMoHo wants to merge 2 commits into
Conversation
…length The custom share link token input accepted arbitrarily long values, while the server (and the oc_share.token database column) only allows 32 characters. Users learned about the limit only after submitting the form and reading the error toast. Set the maxlength attribute on the token input matching ShareAPIController::TOKEN_MAX_LENGTH and mention the length and character constraints in the helper text, so the limit is communicated before saving instead of after a failed request. Related: nextcloud#61416, follow-up to nextcloud#61630 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: MiMoHo <37556964+MiMoHo@users.noreply.github.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: MiMoHo <37556964+MiMoHo@users.noreply.github.com>
MiMoHo
requested review from
nfebe,
skjnldsv and
susnux
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The custom share link token input accepts arbitrarily long values, while the server (and the
oc_share.tokendatabase column) only allows 32 characters. Before #61630 this failed at the database layer with a generic "Failed to update share."; since #61630 the server returns a descriptive validation message — but in both cases users only learn about the limit after submitting the form.This communicates the constraint up front:
maxlengthon the token input, matchingShareAPIController::TOKEN_MAX_LENGTH(32), so the input simply cannot exceed the limit, andTesting
Verified against a local instance (Playwright):
maxlength="32",Related: #61416 — follow-up to #61630 (server-side validation).
🤖 Generated with Claude Code