Validate wiki universal identifier, disallow updating it#24085
Open
NobodysNightmare wants to merge 2 commits into
Open
Validate wiki universal identifier, disallow updating it#24085NobodysNightmare wants to merge 2 commits into
NobodysNightmare wants to merge 2 commits into
Conversation
This check is intended to detect whether the installation id of an instance changed, which would point at the possibility that the underlying XWiki instance changed. If that was the case, previous links might not work anymore.
We do not support changing the actual instance identity under the same configured provider on the OpenProject side. If someone changes the URL and this changes the identity of the remote XWiki instance, this would mean that existing access tokens and page links are most likely broken. Thus we stop updating the instance id, after it was initially fetched. The previously created health check will ensure to notify users of such an error. For the rare cases where the change of the installation id might be an error and everything is fine otherwise, this will mean that a manual change via the rails console would be necessary.
|
Warning This pull request does not link an OpenProject work package. Please add a link to the work package in the description, or reference it in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a health check to confirm that the ID didn't change compared to setup and stop updating it during provider updates.
(see commits for more details)