[BNE-99] Replace pastededuplicate#24094
Draft
judithroth wants to merge 2 commits into
Draft
Conversation
3 tasks
… after adding a wp link https://community.openproject.org/wp/COMMS-806 This was fixed in op-blocknote-extension; however, we can't have a spec for it there since it needs yjs / hocuspocus to reproduce.
https://community.openproject.org/wp/BNE-99 This is still work in progress and waits for the release of op-blocknote-extensions with the corresponding implementation!
judithroth
force-pushed
the
code-maintenance/bne-99-replace-pastededuplicate
branch
from
89850fa to
25fc8fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://community.openproject.org/wp/BNE-99
What are you trying to accomplish?
Simplify op-blocknote-extensions and how it is set up.
This also adds a test for [COMMS-806] Documents: impossible to delete characters with backspace after adding a wp link which is not yet released as well.
Screenshots
What approach did you choose and why?
Remove all event handling which needed to be set up in the editor
Merge checklist
Matching PR in op-blocknote-extensions: opf/op-blocknote-extensions#176