[FSSDK-12865] url parse fix#1161
Merged
Merged
Conversation
|
coverage: 77.701% (-0.02%) from 77.724% — junaed/fssdk-12865-url-parse-alt into master |
There was a problem hiding this comment.
Pull request overview
This PR updates the Node.js HTTP request handler to stop using the deprecated legacy url.parse() API and instead parse request URLs using the WHATWG URL constructor, adding error handling for malformed URLs.
Changes:
- Replaced legacy URL parsing (
url.parse) withnew URL(requestUrl)in the Node request handler. - Added a
try/catcharound URL construction to gracefully reject malformed URLs. - Updated request option construction to work with WHATWG
URLfields (pathname/search).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
91
to
94
| hostname: url.hostname, | ||
| path: url.path, | ||
| port: url.port, | ||
| path: url.pathname + url.search, | ||
| port: url.port || null, | ||
| protocol: url.protocol, |
raju-opti
approved these changes
Jul 7, 2026
raju-opti
left a comment
raju-opti
left a comment
Contributor
There was a problem hiding this comment.
approving with one comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Existing tests should pass
Issues