Skip to content

Access tokens are now optional with Meta #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oscarotero merged 2 commits into from
Jul 8, 2026
+6 −14
Merged

Access tokens are now optional with Meta #577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60c2ae5
Access tokens are now optional with Meta
Jul 8, 2026
fbc2e1d
Update Instagram to v25
Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions src/Adapters/Facebook/OEmbed.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,14 @@

class OEmbed extends Base
{
const ENDPOINT_PAGE = 'https://graph.facebook.com/v11.0/oembed_page';
const ENDPOINT_POST = 'https://graph.facebook.com/v11.0/oembed_post';
const ENDPOINT_VIDEO = 'https://graph.facebook.com/v11.0/oembed_video';
const ENDPOINT_PAGE = 'https://graph.facebook.com/v25.0/oembed_page';
const ENDPOINT_POST = 'https://graph.facebook.com/v25.0/oembed_post';
const ENDPOINT_VIDEO = 'https://graph.facebook.com/v25.0/oembed_video';

protected function detectEndpoint(): ?UriInterface

Check failure on line 15 in src/Adapters/Facebook/OEmbed.php

View workflow job for this annotation

GitHub Actions / PHPStan Static Analysis 

Method Embed\Adapters\Facebook\OEmbed::detectEndpoint() never returns null so it can be removed from the return type.
{
$token = $this->extractor->getSetting('facebook:token');

if (!is_string($token) || $token === '') {
return null;
}

$uri = $this->extractor->getUri();
if (strpos($uri->getPath(), 'login') !== false) {
parse_str($uri->getQuery(), $params);
Expand All @@ -28,7 +24,7 @@
}
}
$queryParameters = $this->getOembedQueryParameters((string) $uri);
$queryParameters['access_token'] = $token;
if($token) $queryParameters['access_token'] = $token;

Check failure on line 27 in src/Adapters/Facebook/OEmbed.php

View workflow job for this annotation

GitHub Actions / PHPStan Static Analysis 

Only booleans are allowed in an if condition, mixed given.

return $this->extractor->getCrawler()
->createUri($this->getEndpointByPath($uri->getPath()))
Expand Down
8 changes: 2 additions & 6 deletions src/Adapters/Instagram/OEmbed.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,23 +8,19 @@

class OEmbed extends Base
{
const ENDPOINT = 'https://graph.facebook.com/v8.0/instagram_oembed';
const ENDPOINT = 'https://graph.facebook.com/v25.0/instagram_oembed';

protected function detectEndpoint(): ?UriInterface

Check failure on line 13 in src/Adapters/Instagram/OEmbed.php

View workflow job for this annotation

GitHub Actions / PHPStan Static Analysis 

Method Embed\Adapters\Instagram\OEmbed::detectEndpoint() never returns null so it can be removed from the return type.
{
$token = $this->extractor->getSetting('instagram:token');

if (!is_string($token) || $token === '') {
return null;
}

$uri = $this->extractor->getUri();
if (strpos($uri->getPath(), 'login') !== false) {
$uri = $this->extractor->getRequest()->getUri();
}

$queryParameters = $this->getOembedQueryParameters((string) $uri);
$queryParameters['access_token'] = $token;
if($token) $queryParameters['access_token'] = $token;

Check failure on line 23 in src/Adapters/Instagram/OEmbed.php

View workflow job for this annotation

GitHub Actions / PHPStan Static Analysis 

Only booleans are allowed in an if condition, mixed given.

return $this->extractor->getCrawler()
->createUri(self::ENDPOINT)
Expand Down
Loading