Support doctrine 4#39
Merged
Merged
Conversation
kimpepper
reviewed
Jul 6, 2026
kimpepper
left a comment
kimpepper
left a comment
Member
There was a problem hiding this comment.
Reviewed the new GitHub Actions workflow.
- PHP provisioning: We don't usually use
shivammathur/setup-php. Suggested running the job inside the standard Skpr PHP CLI container (skpr/php-cli:<version>-dev-v2-latest), which ships Composer and git. - Action versions:
actions/checkout@v4andactions/upload-artifact@v4are ~3 majors behind; bumped to the latest (v7). - Composer:
--no-suggestwas removed in Composer 2.
Note: -latest image tags float the PHP patch version, which is fine for CI and consistent with other Skpr projects.
kimpepper
reviewed
Jul 6, 2026
kimpepper
left a comment
kimpepper
left a comment
Member
There was a problem hiding this comment.
Follow-up to the previous review: instead of emitting a JUnit XML artifact, use a PHPUnit problem matcher so test failures surface inline as annotations. This supersedes the earlier upload-artifact@v7 suggestion.
…poser.lock - Set PHP minimum to 8.2 - Bump dev dependencies to highest minor+patch (coder 9, phpcs 4, phpstan 2, phpunit 11) - Migrate phpunit.xml.dist to PHPUnit 11 schema - Convert @group annotation to #[Group] attribute - Remove abandoned pear/console_table and unused printTree() debug helper - Remove redundant always-true assert($stmt instanceof Result) calls - Fix Drupal 9.x coding standard whitespace - Untrack and gitignore composer.lock (library)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drupal 12 require symfony 8
Symfony 8 requires doctrine 4+
Additional high-level changes in this PR:
--teamcityproblem matcher and PHPCS to checkstyle +cs2prfor inline annotations.pear/console_tableandphpcompatibility/php-compatibility; addedcs2pr.composer.lockand added it to.gitignore(library convention).phpunit.xml.distto the PHPUnit 11 schema and@groupannotation to a#[Group]attribute.