feat: deprecate non-int/float values in Gauge::set()#15
Merged
Conversation
Passing a value that is not an int or float to Gauge::set() now triggers an E_USER_DEPRECATED notice. The value is still stored, so behaviour is unchanged. The parameter type will be narrowed to int|float in the next major release. Also documents the encode() parameters in PrometheusEncoder so the missing iterable value-type ignore is no longer needed. Closes #14
kimpepper
force-pushed
the
feat/deprecate-gauge-mixed-value
branch
from
48be809 to
91c4079
Compare
acbramley
reviewed
Jul 10, 2026
The TriggerErrorSeeUrlFormat sniff requires drupal.org URLs, which does not apply to this GitHub project. Exclude it globally instead of using an inline phpcs:ignore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing a value that is not an int or float to
Gauge::set()now triggers anE_USER_DEPRECATEDnotice; values are still stored so behaviour is unchanged. The parameter type will be narrowed toint|floatin 2.0.0.Closes #14