feat: deprecate non-int values in Counter::set()#17
Merged
Conversation
kimpepper
requested review from
acbramley and
Copilot
and removed request for
Copilot
Passing a non-int value to Counter::set() now triggers an E_USER_DEPRECATED notice before the existing InvalidArgumentException is thrown. The parameter type will be narrowed to int in the next major release. Documents the value as int<0, max>. Closes #16
The TriggerErrorSeeUrlFormat sniff is now excluded globally in phpcs.xml, so the inline phpcs:ignore is no longer needed.
kimpepper
force-pushed
the
feat/deprecate-counter-mixed-value
branch
from
371514b to
a84657b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing a non-int value to
Counter::set()now triggers anE_USER_DEPRECATEDnotice before the existingInvalidArgumentExceptionis thrown; behaviour is otherwise unchanged. The parameter type will be narrowed tointin 2.0.0.Closes #16