Delete obsolete .cargo/config.toml#979
Open
emilazy wants to merge 1 commit into
Open
Conversation
Maturin adds these flags by itself, but the presence of this file can seemingly cause them to not get added at all in some environments, likely related to them using their own `.cargo/config.toml` file. This was possibly caused by <PyO3/maturin@74baa67>, as we noticed it when bumping Maturin past that commit in Nixpkgs. Removing the file fixes the macOS build in our environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maturin adds these flags by itself, but the presence of this file can seemingly cause them to not get added at all in some environments, likely related to them using their own
.cargo/config.tomlfile.This was possibly caused by PyO3/maturin@74baa67, as we noticed it when bumping Maturin past that commit in Nixpkgs. Removing the file fixes the macOS build in our environment.
Pull Request Check List