[CodeQuality] Add CallbackSingleAssertToSimplerRector to simplify single-assert callback matchers in with()#714
Merged
Merged
Conversation
…VoidMethodMockCallbackRector void callbacks
…lback in with() to equalTo() matcher
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
CallbackSingleAssertToSimplerRector.A
->with()callback matcher that only does a singleassertSame()+return true;is just a verboseequalTo(). This rule collapses it to the native matcher.$builder->expects($this->exactly(2)) ->method('add') - ->with($this->callback(function ($type): bool { - $this->assertSame(TextType::class, $type); - - return true; - })); + ->with($this->equalTo(TextType::class));Handles multiple
with()args independently.Skips when the callback does more than
assertSame()+return true;(a different assert, extra statements, or a non-truereturn), so matcher behavior is preserved.Registered in the
phpunit-code-qualityset.Also loops all
with()args in the siblingSimplerWithIsInstanceOfRector(was first-arg only), soassertInstanceOfcallbacks convert in any position: