Skip to content

Show onward replication status on replicas#6224

Merged
bert-e merged 1 commit into
development/9.4from
improvement/CLDSRV-931/replication-status
Jul 9, 2026
Merged

Show onward replication status on replicas#6224
bert-e merged 1 commit into
development/9.4from
improvement/CLDSRV-931/replication-status

Conversation

@maeldonn

@maeldonn maeldonn commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Report the onward status (PENDING/PROCESSING/FAILED) instead of always REPLICA, and add x-amz-meta-replica to keep the replica flag visible.

Issue: CLDSRV-931

@maeldonn maeldonn requested review from a team, SylvainSenechal and delthas July 8, 2026 17:03
@bert-e

bert-e commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Hello maeldonn,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue CLDSRV-931 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.4.0

Please check the Fix Version/s of CLDSRV-931, or the target
branch of this pull request.

Comment thread lib/utilities/collectResponseHeaders.js Outdated
@bert-e

bert-e commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@maeldonn maeldonn force-pushed the improvement/CLDSRV-931/replication-status branch from 7ca11e8 to e34472f Compare July 8, 2026 17:21
Comment thread lib/utilities/collectResponseHeaders.js Outdated
Comment thread tests/unit/utils/collectResponseHeaders.js
@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
9671 1 9670 0
View the full list of 1 ❄️ flaky test(s)
"after each" hook for "should fail if trying to overwrite a delete marker"::MPU with x-scal-s3-version-id header With v4 signature "after each" hook for "should fail if trying to overwrite a delete marker"

Flake rate in main: 100.00% (Passed 0 times, Failed 219 times)

Stack Traces | 0.015s run time
We encountered an internal error. Please try again.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@maeldonn maeldonn force-pushed the improvement/CLDSRV-931/replication-status branch from e34472f to 3195b2d Compare July 8, 2026 17:30
Comment thread lib/utilities/collectResponseHeaders.js

@delthas delthas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM code-wise.

Comment thread lib/utilities/collectResponseHeaders.js Outdated
@bert-e

bert-e commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

The following reviewers are expecting changes from the author, or must review again:

Report the onward status (PENDING/PROCESSING/FAILED) instead of always
REPLICA, and add x-amz-meta-replica to keep the replica flag visible.

Issue: CLDSRV-931
@maeldonn maeldonn force-pushed the improvement/CLDSRV-931/replication-status branch from 3195b2d to a6adc2d Compare July 9, 2026 09:40
@maeldonn maeldonn requested a review from SylvainSenechal July 9, 2026 09:44

@SylvainSenechal SylvainSenechal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe can ask Florent if he wants
responseMetaHeaders['x-amz-meta-scal-replica'] = 'false';

When the object is not a replica, or if current solution (returns nothing is enough)

@bert-e

bert-e commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@maeldonn

maeldonn commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

@SylvainSenechal We omit this header to maintain consistency with the other headers.

@maeldonn

maeldonn commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

/approve

@bert-e

bert-e commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.4

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8
  • development/9.0
  • development/9.1
  • development/9.2
  • development/9.3

This pull request did not target the following hotfix branch(es) so they
were left untouched:

  • hotfix/7.10.0
  • hotfix/9.2.24
  • hotfix/7.4.8
  • hotfix/7.4.0
  • hotfix/7.70.51
  • hotfix/7.10.4
  • hotfix/7.10.3
  • hotfix/7.10.28
  • hotfix/7.4.6
  • hotfix/7.10.2
  • hotfix/7.4.1
  • hotfix/7.10.8
  • hotfix/7.4.4
  • hotfix/9.2.36
  • hotfix/7.70.73
  • hotfix/7.10.49
  • hotfix/7.9.0
  • hotfix/6.4.7
  • hotfix/7.10.30
  • hotfix/9.0.32
  • hotfix/7.4.5
  • hotfix/7.2.0
  • hotfix/7.70.11
  • hotfix/7.4.10
  • hotfix/7.10.1
  • hotfix/7.4.3
  • hotfix/7.70.45
  • hotfix/7.7.0
  • hotfix/7.70.21
  • hotfix/7.10.15
  • hotfix/7.10.27
  • hotfix/7.8.0
  • hotfix/7.6.0
  • hotfix/8.8.45
  • hotfix/7.4.2
  • hotfix/7.4.7
  • hotfix/9.0.7
  • hotfix/7.4.9

Please check the status of the associated issue CLDSRV-931.

Goodbye maeldonn.

The following options are set: approve

@bert-e bert-e merged commit a6adc2d into development/9.4 Jul 9, 2026
61 of 63 checks passed
@bert-e bert-e deleted the improvement/CLDSRV-931/replication-status branch July 9, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants