Update donation CTA with new copy and image#2139
Open
jagerman wants to merge 7 commits into
Open
Conversation
Add a Localization and Translations section (after UI Architecture) explaining that strings.xml files are generated from Crowdin and must not be hand-edited, that the sync automation lives in session-shared-scripts, the approved-only export gate, and the ordering for shipping a text change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Refresh the donation call-to-action shown on the home screen: - point DonationDialog at the new ongoingAppeal / ongoingAppealDescription string keys (the "New hope for Session" copy) instead of finalAppeal* - replace the hero image (cta_hero_donation.webp) - bump the donation preference keys v3 -> v4 so the refreshed CTA is shown again to users who had already dismissed the previous one The ongoingAppeal* keys are supplied by the Crowdin sync; this will not compile until that translations PR lands them in strings.xml. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
mpretty-cyro
approved these changes
Jul 6, 2026
README linked to BUILDING.md, which does not exist. The build instructions live in RELEASE.md; point the link there. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The release script never imports fdroidserver as a library — it only shells out to the `fdroid` command. Using uv + PEP 723 inline metadata to spin up a venv just to put that one binary on PATH was disproportionate. Run as a plain python3 script instead and require fdroidserver to be installed on the system (apt / brew / port), which is how everything else (gh, JDK, SDK) is already expected. The missing-fdroid error and RELEASE.md now point at the package managers and the official install docs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Capture the toolchain, flavors/build types, the play build + emulator install commands, and the Crowdin "strings.xml is generated, don't hand-edit" gotcha (pointing at ARCHITECTURE.md §13) so future sessions can pick it up. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Two small stdlib-python helpers that automate the mechanical, decision-free parts of cutting a release: - prepare-release.py <version> [--from <branch>]: fork the release branch off master (or a chosen base), commit the versionCode/versionName bump, push, and create a GitHub draft release with placeholder notes. Stops there so the maintainer can merge/cherry-pick the release content themselves. - update-release-notes.py <version>: (re)generate the changelog via GitHub's own release-notes generator for the finalized branch and overwrite the draft's body. Run after merges and before the PGP signing step (it overwrites the whole body). The publish/merge gates (Play upload, F-Droid PR merge, draft publish) remain deliberately manual. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signing/publishing credentials no longer sit on disk in plaintext: - add scripts/_keyring.py: a small cross-platform helper over the `keyring` library (macOS Keychain, Linux Secret Service, etc.) with a set/get/del CLI. - build-and-release.py now reads release-creds (the TOML blob) from the keyring instead of release-creds.toml on disk. - add scripts/upload-to-play.py: uploads the release AAB to Google Play via the Play Developer API, reading the service-account JSON key from the keyring. Defaults to leaving the release as a draft; --submit sends it for review. - RELEASE.md: document keyring-based credential storage, the new scripts, and the Play upload step; drop the "place release-creds.toml in the project root" instructions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refresh the donation call-to-action shown on the home screen:
string keys (the "New hope for Session" copy) instead of finalAppeal*
again to users who had already dismissed the previous one
The ongoingAppeal* keys are supplied by the Crowdin sync (#2138); this PR includes those changes (needed for successful compilation).
Also updates ARCHITECTURE.md with translation generation details, which weren't mentioned at all.