Shorten label: s/Inline discussions/Discussions#11
Conversation
|
@francisschmaltz do you know how theming works for icons contributed by extensions? couldn't figure out how to get two different colors there for light/dark theme, and not aware of any extension that uses icons in this way. (cc @sqs in case you know how this works). Any suggestions on how to get around this otherwise? |
|
@attfarhan can you add current screenshots |
emidoots
left a comment
emidoots
left a comment
There was a problem hiding this comment.
Nice, this looks great! I've wanted this for a long time :)
Let's fix the dark theme icon before merging though, for sure.
|
@francisschmaltz those in the issue description are the latest screenshots. As we discussed I didn't use the CSS hack, hence why I haven't merged. |
|
@francisschmaltz I made the icon have color |
francisschmaltz
left a comment
francisschmaltz
left a comment
There was a problem hiding this comment.
This looks bad right now. Either we should special case it, or do this the right way (API for sending an SVG that we can change the color).
attfarhan
changed the title
|
Updated this to just say "Discussions" instead of "Inline discussions" as per https://github.com/sourcegraph/sourcegraph/issues/1178#issuecomment-453588982. |
3 participants
Part of https://github.com/sourcegraph/sourcegraph/issues/1178.
Updates the label to be just a chat bubble icon, rather than "Inline discussions".
Also adds the parcel
serveandbuildscripts like the new extensions have.Screenshots:
GitHub:
Sourcegraph:
Light theme:
Dark theme:
