Skip to content

fix(proto): the one vm file#21679

Merged
dashrews78 merged 1 commit into
masterfrom
dashrews/fix-virtualmachine-style
Jul 10, 2026
Merged

fix(proto): the one vm file#21679
dashrews78 merged 1 commit into
masterfrom
dashrews/fix-virtualmachine-style

Conversation

@dashrews78

@dashrews78 dashrews78 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Description

Streams got crossed between changes, so #21659 missed this one.

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

CI

@dashrews78

Copy link
Copy Markdown
Contributor Author

This change is part of the following stack:

Change managed by git-spice.

@vjwilson vjwilson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.34%. Comparing base (7be78d2) to head (4199bef).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21679      +/-   ##
==========================================
- Coverage   50.38%   50.34%   -0.05%     
==========================================
  Files        2846     2846              
  Lines      218351   218351              
==========================================
- Hits       110021   109924      -97     
- Misses     100346   100424      +78     
- Partials     7984     8003      +19     
Flag Coverage Δ
go-unit-tests 50.34% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dashrews78 dashrews78 enabled auto-merge (squash) July 10, 2026 14:40
@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

🚀 Build Images Ready

Images are ready for commit 7fad74f. To use with deploy scripts:

export MAIN_IMAGE_TAG=4.12.x-456-g7fad74fc7e

@dashrews78

Copy link
Copy Markdown
Contributor Author

/test gke-ui-e2e-tests

@dashrews78 dashrews78 merged commit 7fad74f into master Jul 10, 2026
113 of 117 checks passed
@dashrews78 dashrews78 deleted the dashrews/fix-virtualmachine-style branch July 10, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants