Skip to content

cp: don't hang forever when the backup destination is a fifo#13344

Open
Chaganti-Reddy wants to merge 1 commit into
uutils:mainfrom
Chaganti-Reddy:cp-backup-fifo-hang
Open

cp: don't hang forever when the backup destination is a fifo#13344
Chaganti-Reddy wants to merge 1 commit into
uutils:mainfrom
Chaganti-Reddy:cp-backup-fifo-hang

Conversation

@Chaganti-Reddy

Copy link
Copy Markdown
Contributor

cp --backup opens the backup path for writing to copy into it, but if something's already sitting there as a fifo (or socket) that just blocks forever waiting for a reader — GNU just replaces it. removed it first in backup_dest, same as the rest of cp already does when overwriting the destination itself.

Fixes #13162

@github-actions

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Note: The gnu test tests/csplit/csplit-heap is now being skipped but was previously passing.
Congrats! The gnu test tests/tail/pipe-f is now passing!
Skip an intermittent issue tests/pr/bounded-memory (was skipped on 'main', now failing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(cp): when <DST>existing is created by mkfifo a pipe, it hangs forever

1 participant