ln: don't refuse --backup when src/dst are different names for the same inode#13345
Open
Chaganti-Reddy wants to merge 2 commits into
Open
ln: don't refuse --backup when src/dst are different names for the same inode#13345Chaganti-Reddy wants to merge 2 commits into
Chaganti-Reddy wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ln --backup was rejecting any src/dst pair that happened to share an inode, even when they're two different hard-linked names - GNU only refuses when dst is the only remaining name for that inode (nlink == 1) or src/dst are literally the same entry. reused the canonicalize-based check the -f branch already had right, applied it to the backup check too. the fifo symptom in the issue was just a side effect of the early bail-out never reaching the actual backup rename.
Fixes #13166