find: -printf: fix %A+/%C+/%T+ fractional seconds to match GNU#757
Open
leeewee wants to merge 1 commit into
Open
find: -printf: fix %A+/%C+/%T+ fractional seconds to match GNU#757leeewee wants to merge 1 commit into
leeewee wants to merge 1 commit into
Conversation
The `%+` format used chrono's `%.f`, which trims trailing zeros and omits the fraction when it is zero — so a whole-second timestamp printed `…:200` instead of GNU's `…:20.0000000000`. Use fixed-width `.%f`, matching GNU's `.%09ld0`.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #757 +/- ##
=======================================
Coverage 91.88% 91.88%
=======================================
Files 35 35
Lines 7159 7159
Branches 377 377
=======================================
Hits 6578 6578
Misses 437 437
Partials 144 144 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Commit 98bfad2 has test result changes: bfs testsuite: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-printf%A+/%C+/%T+diverged from GNU on low-precision timestamps. The%+format expanded to…%S%.f0, using chrono's%.f, which trims trailing zeros and omits the fraction entirely when it is zero. GNU always writes a fixed-width fraction (snprintf(".%09ld0", tv_nsec)infind/print.c).Before:
After — matches GNU byte-for-byte across ns = 0 / microsecond / full precision:
The fix uses
.%f(literal dot + fixed 9-digit%f), like the%Sand ctime paths already do. As a side effect it makes the existingfind_printftest's%A+assertion deterministic (always.NNNNNNNNN0), which removes the intermittent Windows CI failure seen on that test.