Skip to content

ignore unrecognized URIs#15

Merged
sqs merged 1 commit into
masterfrom
ignore-unrecognized-uris
Aug 3, 2019
Merged

ignore unrecognized URIs#15
sqs merged 1 commit into
masterfrom
ignore-unrecognized-uris

Conversation

@sqs

@sqs sqs commented Aug 3, 2019

Copy link
Copy Markdown
Contributor

If a document has a URI other than git: (such as comment:, https:, etc., which occur in new experimental Sourcegraph features), the following error appears in the browser JS console:

Uncaught (in promise) Error: unrecognized URI: "comment://2" (supported URI schemes: git)

This change suppresses that error by skipping the attempt to decorate such files.

If a document has a URI other than `git:` (such as `comment:`, `https:`, etc., which occur in new experimental Sourcegraph features), the following error appears in the browser JS console:

```
Uncaught (in promise) Error: unrecognized URI: "comment://2" (supported URI schemes: git)
```

This change suppresses that error by skipping the attempt to decorate such files.
@sqs sqs requested a review from emidoots August 3, 2019 07:49
@sqs sqs merged commit f8c7148 into master Aug 3, 2019
@sqs sqs deleted the ignore-unrecognized-uris branch August 3, 2019 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant