Skip to content

ignore unrecognized URIs #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sqs merged 1 commit into from
Aug 3, 2019
Merged

ignore unrecognized URIs #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ export function activate(): void {
}

const uri = resolveURI(editor.document.uri)
if (!uri) {
return
}

const threads = await fetchDiscussionThreads({
first: 10000,
Expand Down
4 changes: 2 additions & 2 deletions src/uri.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* Resolve a URI of the forms git://github.com/owner/repo?rev#path and file:///path to an absolute reference, using
* the given base (root) URI.
*/
export function resolveURI(uri: string): { repo: string; rev: string; path: string } {
export function resolveURI(uri: string): { repo: string; rev: string; path: string } | null {
const url = new URL(uri)
if (url.protocol === 'git:') {
return {
Expand All @@ -11,5 +11,5 @@ export function resolveURI(uri: string): { repo: string; rev: string; path: stri
path: url.hash.slice(1),
}
}
throw new Error(`unrecognized URI: ${JSON.stringify(uri)} (supported URI schemes: git)`)
return null
}